Skip to content

Update ~script.py #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Update ~script.py #990

merged 1 commit into from
Jul 11, 2019

Conversation

FrogBattle
Copy link
Contributor

Changing the boolean expression avoids the use of a continue statement.
This way the code becomes easier/faster to compute on lower level and it has a
better coding style.

Changing the boolean expression avoids the use of a continue statement.
This way the code becomes easier/faster to compute on lower level and it has a
better coding style.
@cclauss
Copy link
Member

cclauss commented Jul 10, 2019

@NielXu @qckzr Your reviews please on this proposed change?

Doing Review changes will give project maintainers more confidence that you have read through the actual changes and believe that those changes will improve the state of our project.

Anyone can review a GitHub pull request:

  1. Scroll up on this page and click on Files changed just above the initial commit message.
  2. Click on the green button Review changes
  3. Click on Comment or Approve or Request changes and type a short note.

Thanks for taking the time to go through these extra steps which should help project maintainers.

Copy link
Contributor

@qckzr qckzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Approved.

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your pull request!🤩

@cclauss cclauss merged commit f2eb965 into TheAlgorithms:master Jul 11, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
Changing the boolean expression avoids the use of a continue statement.
This way the code becomes easier/faster to compute on lower level and it has a
better coding style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants